Add s390x support for pump assets #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for building pump assets for the s390x architecture. The changes made to the Dockerfile and build script enable the pump assets to be built and work correctly on the s390x architecture.
Summary of Changes
ci/Dockerfile.stdto add a new build stage for the s390x architecture. The appropriate base image for the s390x architecture is used, and the necessary files are copied and environment variables are set.ci/scripts/build_tyk.shto include the s390x architecture in the list of architectures for which the pump assets are built. The 'for' loop that iterates over the list of architectures is updated to include 's390x'.Please review and merge this pull request to add support for building pump assets for the s390x architecture.
Fixes #699.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.